Separate mac builds to ARM64 and Intel - #346
Conversation
Drops the universal build (and its osxUniversal x64ArchFiles config), so no Intel Mac artifact is produced anymore.
volume names over 27 chars and the versioned file name exceeds that. Drop zip artifacts
binary; the release step builds them sequentially since appdmg mounts a volume per dmg.
|
|
||
| Promise.all(platforms.map(packagePlatform)) | ||
| .then(() => done()) | ||
| .catch(err => { |
There was a problem hiding this comment.
Currently, this catch() will log the error and then call done(), allowing the build to continue. I think we should consider erroring out instead so that we don't accidentally (and silently) release a broken build.
There was a problem hiding this comment.
by adding the error object as an argument of done function, we break the build process.
There was a problem hiding this comment.
Not part of your change, but again I think we should consider catching errors here and failing the build.
| const options = { | ||
| appPath: buildPath, | ||
| name: name, | ||
| title: APP_NAME, |
There was a problem hiding this comment.
If you made the title APP_NAME + "-" + ${arch}, would that remove the need for the "tricky" code below? It might let you run the builds in parallel too.
| throw new Error('Missing build'); | ||
| } | ||
|
|
||
| const linuxDest = `${RELEASE_DIR}BTT-Writer-${packageJson.version}-linux-x64.zip`; |
There was a problem hiding this comment.
Can we keep the Linux .zip download? The .deb target only works for Debian-based Linux targets.
41eb656 to
4e06aca
Compare
Use unique titles for Mac dmgs for parallel build
2 participants
Fixes # .
Changes in this pull request: